CP-54020: Refactor sxm and storage_mux code #6378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
9e042ba to
544bbdd
Compare
psafont
reviewed
Mar 20, 2025
psafont
approved these changes
Mar 20, 2025
gthvn1
reviewed
Mar 20, 2025
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
544bbdd to
7528ee4
Compare
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
contificate
reviewed
Mar 20, 2025
|
I've provided a number of nitpicks (feel free to ignore), but I generally like the usage of modules to structure this nicely. |
I think some of these are good comments, I have fixed them accordingly. |
This split is so that this part can be used by storage_migrate later on for its own multiplexing logic, to avoid dependency cycle. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
This is then used later for storage_migrate to multiplex based on the SMAPI version. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
This will be used later on to define the interface a migration module should implement. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
19135d0 to
9bf0661
Compare
psafont
reviewed
Mar 25, 2025
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
9bf0661 to
3017b94
Compare
|
I have changed the PR a bit with an additional change to the quality gate as well, let me know if there are any concerns around this |
psafont
reviewed
Mar 26, 2025
lindig
approved these changes
Mar 26, 2025
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
43b4085 to
1a88a93
Compare
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Use first class modules to generate modules for the remote SMAPIv2 calls to avoid code duplication. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
Vincent-lau
force-pushed
the
private/shul2/sxm-mux
branch
from
1a88a93 to
112ef69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various refactors in this PR, details in each commit message. This is mainly for clean up purposes and also to prepare for the real refactoring of sxm for SMAPIv1 and SMAPIv3.
No functional change.
More to come...